mathpaquette / IQFeed.CSharpApiClient

IQFeed.CSharpApiClient is fastest and the most well-designed C# DTN IQFeed socket API connector available
MIT License
121 stars 42 forks source link

Downgrade/Support .net-framework version from .net462 to .net45. #5

Closed Nucs closed 6 years ago

Nucs commented 6 years ago

As a library, .net-framework version should be supported at lowest version possible. Therefore .net-framework version should be downgraded or even better also support .net45, Below .net45 there will be needed heavier changes related to TPL and Tasks.

In .net45 there is no System.Configuration.ConfigurationManager, Use mscorlib's assembly System.Configuration instead.

Nucs commented 6 years ago

I've already added support for .net45 it in my local private fork. Assign it to me and I'll add a pull request.

mathpaquette commented 6 years ago

@Nucs Since now we are supporting .net core 2, I had an issue with System.Configuration targeting .net45. .net core still work fine?

mathpaquette commented 6 years ago

just say your comment about mscorlib...

mathpaquette commented 6 years ago

@Nucs after this one, I can release 1.3.1