Hibernate search 5.9.1 and sortable

mathpere / grails-hibernate-search-plugin

Integrates Hibernate Search features to Grails

http://grails.org/plugin/hibernate-search

Apache License 2.0

21 stars 18 forks source link

Hibernate search 5.9.1 and sortable #41

Closed olliefreeman closed 6 years ago

olliefreeman commented 6 years ago

Updates to 5.9.1
Adds sortable fields
Adds simple query strings
Updates/refactors code
Removes filter as this has now been deprecated
Updated readme
Updated version to 2.3.0-SNAPSHOT

lgrignon commented 6 years ago

Thank you for your contribution! It seems that you did a pretty amazing job with this upgrade / refactoring.

How much did you test? Is it possible that you try to use your plugin on this showcase project and PR?: https://github.com/lgrignon/grails3-quick-start ? That would be great. I will also test it on another project I have to guarantee maximum testing.

Thanks again

olliefreeman commented 6 years ago

We have a (private) project which extensively uses the hibernate search functionality and i'm in the process of running its tests through now. However I have manually tested the changes along with updating our project to use the simple query strings and done some manual testing.

If i had more time i would write some tests for the plugin however unfortunately I have run out of time :(

I will try and add/update to the quick start repo.

lgrignon commented 6 years ago

Awesome, thanks.

olliefreeman commented 6 years ago

pushed updates to resolve comments and missing README section

olliefreeman commented 6 years ago

also all tests on our project have passed

lgrignon commented 6 years ago

Released to: https://bintray.com/lgrignon/plugins/hibernate-search/2.3.0

Showcase updated: https://github.com/lgrignon/grails3-quick-start/commit/1c6671e1f0f5ee4b8ed2b34b8d260485fd0133dd

Thanks again for your contribution!