search

mathpere / grails-hibernate-search-plugin

Integrates Hibernate Search features to Grails
http://grails.org/plugin/hibernate-search
Apache License 2.0
21 stars 18 forks source link

Upgrading to Grails 4 #45

Open mtgleeson opened 4 years ago

mtgleeson commented 4 years ago

Hi, I've recently started using the Hibernate Search plugin with Grails 4. As a FYI, it works fine but I had to override the following dependency in build.gradle to get search working: compile "org.hibernate:hibernate-search-orm:5.11.4.Final"

The version is compatible with hibernate core 5.4.0 (used in Grails 4) - http://hibernate.org/search/releases/5.11/

lgrignon commented 4 years ago

Hello @mtgleeson, that's nice, thanks. Could you submit a PR with your fix so everyone could enjoy it please?

Thanks again

benfreefly commented 4 years ago

@mtgleeson I would also be interested in trying your Grails 4 version. Could you make a PR or check-in a forked repo?

mtgleeson commented 4 years ago

Hi @lgrignon - apologies I just saw your message.

I didn't have to make any changes to the plugin to get it working. Version 2.3.0 works fine with Grails 4. The only change I had to make was to force the plugin to use hibernate-search-orm verison 5.11.4.Final.

i.e. in my app's build.gradle: compile "org.grails.plugins:hibernate-search:2.3.0" compile "org.hibernate:hibernate-search-orm:5.11.4.Final"

lgrignon commented 4 years ago

Could you please test it https://bintray.com/lgrignon/plugins/hibernate-search/2.4.0

And close issue?

Thanks

langerc commented 4 years ago

Tested with 2.4.0 - before adding search-orm:5.11.4 grails could not find the annotations @Indexed the search() function was not avaiulable. Now it is and indexing works fine. So basic setup works cant tell anything about complex things now.