Open jwmerrill opened 11 months ago
Remove MathQuill's jQuery dependency, and replace it with a few smaller internal libs:
DOMFragment
Fragment
Replace's Mathquill's bespoke HTML string templating system DOMView to render an element to a DOM node given its child blocks: https://github.com/mathquill/mathquill/blob/2573c3a3cf3a97a26fe65e3074b0fd424ca0bc41/src/commands/math.ts#L80-L85
DOMView
Example usage: https://github.com/mathquill/mathquill/pull/1031/files#diff-7c2d826f0b8e66e11528a7f992b1e755f0e505ac76dff64bb1f3f7ee1458c4b7L15-R22
Note: introduces a new interface version (v3) because there were a couple places that the public API was returning jQuery types (or passing them as parameters to callbacks). See changelog for details.
demosinc/mathquill PRs:
demosinc/mathquill
Fixes https://github.com/mathquill/mathquill/issues/1007 Fixes https://github.com/mathquill/mathquill/issues/929 Fixes https://github.com/mathquill/mathquill/issues/870 Fixes https://github.com/mathquill/mathquill/issues/670 Fixes https://github.com/mathquill/mathquill/issues/124
Remove MathQuill's jQuery dependency, and replace it with a few smaller internal libs:
DOMFragment
class to represent and manipulate a contiguous span of sibling DOM nodes. This is closely analogous to MathQuill's existingFragment
class used to represent and manipulate a contiguous span of sibling parse nodes. It replaces uses of jQuery for inserting/removing/moving DOM nodes and class manipulation: https://github.com/mathquill/mathquill/blob/2573c3a3cf3a97a26fe65e3074b0fd424ca0bc41/src/domFragment.ts#L2-L4Replace's Mathquill's bespoke HTML string templating system
DOMView
to render an element to a DOM node given its child blocks: https://github.com/mathquill/mathquill/blob/2573c3a3cf3a97a26fe65e3074b0fd424ca0bc41/src/commands/math.ts#L80-L85Example usage: https://github.com/mathquill/mathquill/pull/1031/files#diff-7c2d826f0b8e66e11528a7f992b1e755f0e505ac76dff64bb1f3f7ee1458c4b7L15-R22
Note: introduces a new interface version (v3) because there were a couple places that the public API was returning jQuery types (or passing them as parameters to callbacks). See changelog for details.
demosinc/mathquill
PRs:Fixes https://github.com/mathquill/mathquill/issues/1007 Fixes https://github.com/mathquill/mathquill/issues/929 Fixes https://github.com/mathquill/mathquill/issues/870 Fixes https://github.com/mathquill/mathquill/issues/670 Fixes https://github.com/mathquill/mathquill/issues/124