maths / moodle-qtype_stack

Stack question type for Moodle
GNU General Public License v3.0
138 stars 147 forks source link

Strange behavior of equivalence reasoning and AlgEquiv with explicitly false equations #1071

Closed Mat-Ge closed 3 months ago

Mat-Ge commented 7 months ago

Equivalence reasoning and AlgEquiv behave strangely with explicitly false equations. Why does it matter whether I write 2=0 or 3=0? grafik grafik

sangwinc commented 3 months ago

The reason for this is the order in which we currently perform checks. We check if the LHS of each equation is the same first. So in

2=0 2=sqrt(5)

the LHS of each is identical. This is a hangover from wanting to check individual pairs of equations, rather than lists of equations. I agree, this inconsistency is bad and I'll fix it. Thanks for the bug report.