Failing unit tests in master from the API

maths / moodle-qtype_stack

Stack question type for Moodle

GNU General Public License v3.0

141 stars 150 forks source link

Closed sangwinc closed 2 months ago

sangwinc commented 3 months ago

I've just noticed that the master branch in Moodle now has some failing unit tests for the code in the API branch. It looks like something has changes in PHP https://github.com/maths/moodle-qtype_stack/actions/runs/9810665112/job/27091276827#step:17:92

Could you take a look please @EJMFarrow? Thanks

EJMFarrow commented 2 months ago

OK, will do.

EJMFarrow commented 2 months ago

The above pull request fixes the PHP upgrade issues. There's still a failed test involving unencapsulated commas, though, which looks like it's to do with other changes. https://github.com/maths/moodle-qtype_stack/actions/runs/9836149331/job/27151249529#step:17:88

sangwinc commented 2 months ago

Thanks for fixing this @EJMFarrow