mathsgrinds
commented
8 years ago Okay, I think that is all in order. Two small errors needed to be fixed (rte2 not playing) and guide doesn’t work when station is closed (so added in a try-except dealey).
Thanks bud.
Stephen Easley-Walsh
https://www.mathsgrinds.ie/ https://www.MathsGrinds.ie
0851263404
* Email confidentiality notice *
This message is private and confidential. If you have received this message in error, please notify me and remove it from your system.
From: Shiny [mailto:notifications@github.com] Sent: Sunday 11 September 2016 23:32 To: mathsgrinds/IETVNOW Subject: [mathsgrinds/IETVNOW] v2.1.6 - Tons of changes. (#12)
Ok so in this it is 100% up to date with your repo I can assure you that, When I finished coding it up - I re-checked your repo and there was still no changes. So its 100% up to date with yours.
Changes:
- Tbh too many to mention here, Ill mention ones I can remember;
- Many Small Code Changes (AGAIN) - YOU WILL NOT NOTICE THEM!
- Guide Re-Fixed (Your "Guide Fixed" commit didnt actually fix it - Atleast for me)
- AerTV fixes to make sure it works;
- Moved the j = login() for it to actually be useful; Also renamed it so it doesnt conflict with AerTV's j = html bit;
- Guide Improvements;
- RTE One +1 Added (AerTV), AerTV Choice for TG4 Added, RTE Two AerTV link changed from "rte-two" to "rte-two" as it seems free users have access to it. RTE News Now AerTV Choice Added;
- Changed Settings.xml heavilly, Instead of the "TV3/3e Stream Choice" thing, Its now set to "Preffered Stream Choice" with options "Official Site, AerTV.ie", If its set to Official Site it will be used wherever it can be used, Otherwise AerTV links will get parsed.
Theres tons more changes ones you arent going to notice. Please can you just copy and paste into the Repo so we can start using Merge again? I assure you it works 100% and is up to date with your repo.
You can view, comment on, or merge this pull request online at:
https://github.com/mathsgrinds/IETVNOW/pull/12
Commit Summary
- Testing AerTV Compatability
- o.o
- Fixed AerTV - Needs Plus Account!
- Merge remote-tracking branch 'refs/remotes/mathsgrinds/master'
- v2.0.9 - Merged wth Mathsgrinds and fixed the TV Guide.
- v2.1.6 - Tons of changes.
File Changes
- M Readme.md https://github.com/mathsgrinds/IETVNOW/pull/12/files#diff-0 (11)
- M addon.xml https://github.com/mathsgrinds/IETVNOW/pull/12/files#diff-1 (10)
- M icon.png https://github.com/mathsgrinds/IETVNOW/pull/12/files#diff-2 (0)
- M main.py https://github.com/mathsgrinds/IETVNOW/pull/12/files#diff-3 (295)
- A resources/logos/RTE1 - Copy.png https://github.com/mathsgrinds/IETVNOW/pull/12/files#diff-4 (0)
- M resources/settings.xml https://github.com/mathsgrinds/IETVNOW/pull/12/files#diff-5 (9)
Patch Links:
- https://github.com/mathsgrinds/IETVNOW/pull/12.patch
- https://github.com/mathsgrinds/IETVNOW/pull/12.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mathsgrinds/IETVNOW/pull/12 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJt0DGbxETHPj57NeSiZOZsJnMblnjJQks5qpIFSgaJpZM4J6H4m . https://github.com/notifications/beacon/AJt0DIrgYCleRORL093ob0ia5ljp9VfBks5qpIFSgaJpZM4J6H4m.gif
rlaphoenix
Ok so in this it is 100% up to date with your repo I can assure you that, When I finished coding it up - I re-checked your repo and there was still no changes. So its 100% up to date with yours.
Changes:
Theres tons more changes ones you arent going to notice. Please can you just copy and paste into the Repo so we can start using Merge again? I assure you it works 100% and is up to date with your repo.
P.S: You should give me "Write Access" so I dont need to use these stupid Pull Requests thing. I could then edit directly to your repo. Of course theres a Trust Issue but its safe :P If I fuckup your repo you can just go back to the last commit # before I screw up your repo (Not that I would ofc)