mathsgrinds
commented
8 years ago In fact it doesn’t cut out J I watched all of the Ireland game this week unbroken.
Stephen Easley-Walsh
https://www.mathsgrinds.ie/ https://www.MathsGrinds.ie
0851263404
* Email confidentiality notice *
This message is private and confidential. If you have received this message in error, please notify me and remove it from your system.
From: Shiny [mailto:notifications@github.com] Sent: Saturday 10 September 2016 08:49 To: mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV Subject: [mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV] Huge Changes by ImReallyShiny v2.1.0 (#7)
Changes:
- AerTV Actually Works Now - Finally;
- It checks if you have AerTV Email and Password configured before it tries to get the data to speed up loading;
- Removed the whole Check() code as in my opinion its REALLY un-necessary, It just makes it take x4 to load and its not ever accurate, Broken links may give a 200 when in reality all it does it close the connection, Good idea, But its just not needed they are official links.
- Changed the Settings a bit;
- Changed the Addons.xml a bit;
- Changed bits of code here and there (Minor);
This WONT be mergable - You need to just copy + paste and overwrite all files with changes, I never had a pull request so im not sure if theres a button to do it or not, If there isnt just download from my fork page and just upload it using whatever you are using.
Manually sorting through the files and copy pasting only sections of the code is a very bad practice - I assure you every bit of code that you want in it - Is in it, Including the 3e() and TV3() things. (I also name changed those to make a bit more sense).
So as I said, Just copy and overwrite the files not sections of code from the files. It will work out better trust me :)
Plus account is still needed, As I explained before the use of many free accounts in theory would work, but that depends on how little and how few would be using them a day, If you want to spend hours making millions of free accounts for everyone. They expire after 10 mins and you dont get more viewing time til 24 hours later and average person watches for like an hour atleast, So thats like 6 accounts per person, there will be many many people be watching at once - You wouldnt even know it, And then thats like 6 hours x 30 people~ = 240 accounts being used / day and what if people fall asleep watching or generally watch for longer? + every 10 mins the video will just cut out and in general that would just piss me off xD
👍
AerTV get reeekt
You can view, comment on, or merge this pull request online at:
https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/7
Commit Summary
- Testing AerTV Compatability
- o.o
- Fixed AerTV - Needs Plus Account!
File Changes
- M Readme.md https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/7/files#diff-0 (11)
- M addon.xml https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/7/files#diff-1 (8)
- M main.py https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/7/files#diff-2 (111)
- M resources/settings.xml https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/7/files#diff-3 (6)
Patch Links:
- https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/7.patch
- https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/7.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mathsgrinds/Kodi-Video-Plugin-Live-Irish-TV/pull/7 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJt0DFjFclIfJofoOyMyl5blWSMsf02Jks5qomEIgaJpZM4J5qaT . https://github.com/notifications/beacon/AJt0DHcC5X0gHuhCDgtJTIoVGQbyZYIiks5qomEIgaJpZM4J5qaT.gif
rlaphoenix
Changes:
This WONT be mergable - You need to just copy + paste and overwrite all files with changes, I never had a pull request so im not sure if theres a button to do it or not, If there isnt just download from my fork page and just upload it using whatever you are using.
Manually sorting through the files and copy pasting only sections of the code is a very bad practice - I assure you every bit of code that you want in it - Is in it, Including the 3e() and TV3() things. (I also name changed those to make a bit more sense).
So as I said, Just copy and overwrite the files not sections of code from the files. It will work out better trust me :)
Plus account is still needed, As I explained before the use of many free accounts in theory would work, but that depends on how little and how few would be using them a day, If you want to spend hours making millions of free accounts for everyone. They expire after 10 mins and you dont get more viewing time til 24 hours later and average person watches for like an hour atleast, So thats like 6 accounts per person, there will be many many people be watching at once - You wouldnt even know it, And then thats like 6 hours x 30 people~ = 240 accounts being used / day and what if people fall asleep watching or generally watch for longer? + every 10 mins the video will just cut out and in general that would just piss me off xD
:+1:
AerTV get reeekt