Improve various CI components

josephlr commented 5 years ago

Depends on #27 for test fixes

This pull request does the following:

Uses the proper images so that toolchains don't have to be redownloaded on each build.
Caches cargo registry for all steps except rustfmt
We run clippy on stable, which fixes #25
We keep running rustfmt on nightly for now, as the .rustfmt.toml uses unstable features.
We keep allow_failures to true on the nightly test, note that this will still make the PR turn Red, even if it doesn't fail the entire build
Adds a build stage to make sure the minimal specified versions work. As a consequence, some versions in the Cargo.toml had to be increased:
- bitflags to 1.0.4 because we need: https://github.com/bitflags/bitflags/pull/165
- log to 0.4.4 because we need: https://github.com/rust-lang-nursery/log/pull/288
Adds some comments explaining how the build stages work

The CI is now faster, simpler, and more reliable.

josephlr commented 5 years ago

I revised this pull request, see the updated description. This is now a general CI fixup CL.

mathstuf commented 5 years ago

Thanks! Could you please rebase now that #27 is merged.

josephlr commented 5 years ago

Thanks! Could you please rebase now that #27 is merged.

Done, nightly tests are still failing, but that should be fixed by #28

mathstuf / rust-keyutils