mathstuf / rust-keyutils

Rust interface to the Linux keyring
BSD 3-Clause "New" or "Revised" License
17 stars 9 forks source link

Remove unused itertools dependency #62

Closed complexspaces closed 2 years ago

complexspaces commented 2 years ago

I was not able to see where this was used, and running cargo build worked correctly.

codecov[bot] commented 2 years ago

Codecov Report

Merging #62 (f205739) into master (3d7bf5a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files          38       38           
  Lines        2378     2378           
=======================================
  Hits         1894     1894           
  Misses        484      484           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d7bf5a...f205739. Read the comment docs.

mathstuf commented 2 years ago

Thanks. However, the other changes to Cargo.toml should not be done; they're there to ensure that minimal versions works.

complexspaces commented 2 years ago

That's my bad, sorry. Everything except removing itertools should be reverted now.

mathstuf commented 2 years ago

Thanks; if you rebase on master, the clippy problems should be resolved.

complexspaces commented 2 years ago

That looks like it worked 🎉

mathstuf commented 2 years ago

Thanks!