mathurinm / celer

Fast solver for L1-type problems: Lasso, sparse Logisitic regression, Group Lasso, weighted Lasso, Multitask Lasso, etc.
https://mathurinm.github.io/celer/
BSD 3-Clause "New" or "Revised" License
198 stars 32 forks source link

DOC - add link to source code #251

Closed Badr-MOUFAD closed 2 years ago

Badr-MOUFAD commented 2 years ago

fixes #250

This adds links to github source code.

Changes are inspired by scikit-learn repo.

codecov-commenter commented 2 years ago

Codecov Report

Merging #251 (517ebd5) into main (806d2c0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files          14       14           
  Lines         998      998           
  Branches      131      131           
=======================================
  Hits          868      868           
  Misses        100      100           
  Partials       30       30           
Flag Coverage Δ
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 806d2c0...517ebd5. Read the comment docs.

mathurinm commented 2 years ago

Nice ! It works on almost all methods, but for some it does not e.g. : https://output.circle-artifacts.com/output/job/d218fa10-2aaf-41cd-ae85-900713ae69fb/artifacts/0/dev/generated/celer.datasets.fetch_libsvm.html#celer.datasets.fetch_libsvm

Do you know why ?

Badr-MOUFAD commented 2 years ago

I inspect the rendered page and it appears that the link to the source code is actually generated yet it 's not active. That's weird !

inspect-doc-devtool

mathurinm commented 2 years ago

there is a \ in front of libsvm.py instead of /, could it be the reason ?

Badr-MOUFAD commented 2 years ago

I don't think so. It is the same for make_correlated_data, however it works.

counter-examples

mathurinm commented 2 years ago

nice one @Badr-MOUFAD