API - expose acceleration params

mathurinm / celer

Fast solver for L1-type problems: Lasso, sparse Logisitic regression, Group Lasso, weighted Lasso, Multitask Lasso, etc.

https://mathurinm.github.io/celer/

BSD 3-Clause "New" or "Revised" License

204 stars 33 forks source link

API - expose acceleration params #267

Closed Badr-MOUFAD closed 2 years ago

Badr-MOUFAD commented 2 years ago

This aims to expose acceleration params to make benchmarking with other solvers much easier.

It will proceed as follows

[x] expose use_acc
[ ] expose K

mathurinm commented 2 years ago

It's a design choice not to expose these parameters, to keep the API simple for main users (see eg #168). If you need them exposed for benchmarking you can push to a branch and install from this branch, but I'm not really in favor of merging this PR.

@agramfort thoughts ?

Badr-MOUFAD commented 2 years ago

I don't have a strong opinion. Whatever you decide.

agramfort commented 2 years ago

agreed. Let's try to keep public API as minimal as possible. To be this becomes relevant if it allows power users to actually get a non-trivial boost

Message ID: @.***>