mathworks / MATLAB-Language-grammar

This repository contains a regular expression based language grammar for MATLAB to be used by GitHub Linguist for highlighting MATLAB code on GitHub
50 stars 17 forks source link

Inline improvements for command syntax #37

Closed ghost closed 3 years ago

ghost commented 3 years ago

Closes #7. Adds semicolon and comment support for command-syntax calls.

ghost commented 3 years ago
ghost commented 3 years ago

@rlivings39 why is function support hacked into vscode-matlab and language-matlab-octave? Could I bake the correct tokens into this repo and sync with reference list?

gauravsavadi commented 3 years ago

@4086606 The reason for not including functions is the cost of keeping the list current every release. Every release, MATLAB introduces new functions, and is it not cost-effective to keep this list current.

ghost commented 3 years ago

What if I put work towards this? I already amassed ~1400 missing builtin functions and assigned appropriate token names to 200. I'm sure after I'm done that a simple JS script can compare the old file with the reference list

ghost commented 3 years ago

This is now ready to merge! (I am happy to contribute my 2500 or so support library mappings to vscode-matlab instead.)

nothans commented 3 years ago

Can you contact me to have the CLA signed? Thanks for the pull request.