search

mathworks / jenkins-matlab-plugin

This plugin enables you to run MATLAB® and Simulink® as part of your Jenkins™ build.
45 stars 52 forks source link

Patch fix for file error issue #317

Closed nbhoski closed 2 months ago

nbhoski commented 2 months ago

This is patch fix for issue reported by Braess Hennings as detailed below.

Details

In various projects the underlying jobs failed with the following error message: ** Finished buildApp ** Closed project 'SignalManagement' {Error using fprintf Invalid file identifier. Use fopen to generate a valid file identifier. Error in ciplugins.jenkins.BuildReportPlugin/runTaskGraph (line 20) fprintf(fID, '%s',s); Error in matlab.buildtool.BuildRunner/evaluateMethodOnPlugins (line 256) [varargout{1:nargout}] = plugin.(methodName)(pluginData); Error in matlab.buildtool.BuildRunner/run (line 222) runner.evaluateMethodOnPlugins("runTaskGraph", runner.PluginData.runTaskGraph); Error in buildtool (line 39) result = runner.run(plan, taskName, taskArgs, runArgs{:}); Error in build_ovChyDDU (line 2) buildtool buildApp("/AppGeneratorOutput", "SignalManager", "SignalManagerApp.mlapp", false) } ERROR: MATLAB error Exit Status: 0x00000001 exit status 1 [Pipeline] } [Pipeline] // dir [Pipeline] } Also: org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 7c7e63c5-6513-4c16-a06c-87c132804be5 com.mathworks.ci.MatlabExecutionException: Received a nonzero exit code 1 while trying to run MATLAB. at com.mathworks.ci.MatlabBuildStepExecution.run(MatlabBuildStepExecution.java:64) at com.mathworks.ci.MatlabBuildStepExecution.run(MatlabBuildStepExecution.java:22) at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) [Pipeline] // catchError

. * The fix checks the fopen() return value and issue a warning() to avoid build failure. * This fix does not provide full solution for the issue and we need to further review this issue in detail. * This fix will just unblock our users to run Build without any failures due to our plugin changes. Regards Nikhil
Vahila commented 2 months ago

Hi, the changes for the patch fix are not failing the build. To reproduce the issue, I arbitrarily sent the build artifact data to a 'artifact.json' file which was already in my workspace. The permissions of the file are changed to throw and error same as the one user is getting. So, without our patch fix, the error is as below: image

With the fix the logs are as shown: image

The build is running successfully but we are showing an incorrect message to the user in the MATLAB Build results summary table: image

nbhoski commented 2 months ago

Hi, the changes for the patch fix are not failing the build. To reproduce the issue, I arbitrarily sent the build artifact data to a 'artifact.json' file which was already in my workspace. The permissions of the file are changed to throw and error same as the one user is getting. So, without our patch fix, the error is as below: image

With the fix the logs are as shown: image

The build is running successfully but we are showing an incorrect message to the user in the MATLAB Build results summary table: image

I have updated the error message from Unable to run a MATLAB build to Unable to generate a build artifact @mw-hrastega what you think ?

mw-hrastega commented 2 months ago

Hi, the changes for the patch fix are not failing the build. To reproduce the issue, I arbitrarily sent the build artifact data to a 'artifact.json' file which was already in my workspace. The permissions of the file are changed to throw and error same as the one user is getting. So, without our patch fix, the error is as below: image With the fix the logs are as shown: image The build is running successfully but we are showing an incorrect message to the user in the MATLAB Build results summary table: image

I have updated the error message from Unable to run a MATLAB build to Unable to generate a build artifact @mw-hrastega what you think ?

Hi, @nbhoski. Your proposed text looks good to me.