mathworks / libmexclass

libmexclass is a MATLAB framework which enables users to implement the functionality of MATLAB classes in terms of equivalent C++ classes using MEX.
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Closes #34, #28, #27, #26 #41

Closed sreeharihegden closed 1 year ago

sreeharihegden commented 1 year ago

Overview

This pull request makes the following changes:

  1. Fix for #34
  2. Also fixes #26, #27, and
  3. 28

Future Directions

N/A

Notes

N/A

sreeharihegden commented 1 year ago

@kevingurney: Thanks for the earlier review feedback. I have resolved all of them. See my comments under each requested change above for the commit details of the fix.

Note that the changes in the PR got simplified as I managed to install libmexclass without using any additional script in the ExternalProject_Add INSTALL_COMMAND. See commit 72a2e7f for this change.

Changes qualified locally on Windows and Mac. Also, the latest commit b66f375 passed on Linux CI, see Actions.

kevingurney commented 1 year ago

Thanks for addressing all my feedback @sreeharihegden! This looks great!