Closed sreeharihegden closed 1 year ago
@kevingurney: Thanks for the earlier review feedback. I have resolved all of them. See my comments under each requested change above for the commit details of the fix.
Note that the changes in the PR got simplified as I managed to install libmexclass
without using any additional script in the ExternalProject_Add INSTALL_COMMAND
. See commit 72a2e7f for this change.
libmexclass/cpp/CMakeLists.txt
.ExternalProject_Add INSTALL_COMMAND
now needs to be simply the CMake command to install.install_libmexclass.cmake
is no longer needed and so removed. Changes qualified locally on Windows and Mac. Also, the latest commit b66f375 passed on Linux CI, see Actions.
Thanks for addressing all my feedback @sreeharihegden! This looks great!
Overview
This pull request makes the following changes:
28
Future Directions
N/A
Notes
N/A