search

mathworks / matlab-azure-devops-extension

Continuous Integration with MATLAB on Azure DevOps
https://marketplace.visualstudio.com/items?itemName=MathWorks.matlab-azure-devops-extension
Other
14 stars 5 forks source link

Don't add the sudo prefix if the sudo program is not on the path #105

Closed sameagen-MW closed 8 months ago

sameagen-MW commented 8 months ago

Also includes dependabot vulnerability updates.

davidbuzinski commented 8 months ago

Looks like this does fix one of the dependabot vulnerabilities, but the rest are in the files

Probably need to go to each of these subdirs and doing an npm audit fix to resolve them because of how this project is structured. It looks like the vulnerability in each of these package-locks is the same and has a breaking change so npm audit fix won't resolve it without --force, and could require some other changes.

We can handle that in a separate PR or in this one, up to you.

Either way, the sudo changes look good!

(P.S. gotta drop that mw mirror of npm!)

sameagen-MW commented 8 months ago

Looks like this does fix one of the dependabot vulnerabilities, but the rest are in the files

  • tasks/install-matlab/v1/package-lock.json
  • tasks/install-matlab/v0/package-lock.json
  • tasks/run-matlab-command/v0/package-lock.json
  • tasks/run-matlab-build/v0/package-lock.json
  • tasks/run-matlab-tests/v0/package-lock.json

Probably need to go to each of these subdirs and doing an npm audit fix to resolve them because of how this project is structured. It looks like the vulnerability in each of these package-locks is the same and has a breaking change so npm audit fix won't resolve it without --force, and could require some other changes.

We can handle that in a separate PR or in this one, up to you.

Either way, the sudo changes look good!

(P.S. gotta drop that mw mirror of npm!)

Yeah, that mirror of npm keeps tripping me up! I'll just revert that commit and make sure that all of the dependency updates make it to the next one.

sameagen-MW commented 8 months ago

WIP, still some commits left to come.