search

mathworks / thingspeak-arduino

ThingSpeak Communication Library for Arduino, ESP8266 and ESP32
https://thingspeak.com
431 stars 231 forks source link

Convert to unsigned long to remove warnings. #89

Open dapostol73 opened 3 months ago

dapostol73 commented 3 months ago

Can you add unsigned to the this line, it will remove warnings about comparing an unsigned long with a signed long at line 1604 & 1655

unsigned long timeoutTime = millis() + TIMEOUT_MS_SERVERRESPONSE;

megaatmega2560\ThingSpeak\src\ThingSpeak.h:1604:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if(millis() > timeoutTime){ megaatmega2560\ThingSpeak\src\ThingSpeak.h:1655:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if(millis() > timeoutTime){

https://github.com/mathworks/thingspeak-arduino/blob/9aceb141281cf0da82a7a187f4528d9bea81f016/src/ThingSpeak.h#L1600