search

matianfu / xxhash

Automatically exported from code.google.com/p/xxhash
Other
0 stars 0 forks source link

xxhash checks for GCC_VERSION >= 430 instead of 403 #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
xxhash checks for GCC_VERSION >= 430 (probably because of this lz4 issue: 
http://code.google.com/p/lz4/issues/detail?id=22) but if I'm not mistaken 
GCC_VERSION=430 would mean that GCC >= 4.30 is required although the last 
release is GCC 4.7. I think GCC_VERSION >= 430 should be replaced with 
GCC_VERSION >= 403 to check for GCC 4.3 or newer?

Original issue reported on code.google.com by jpou...@gmail.com on 17 Dec 2012 at 11:02

GoogleCodeExporter commented 9 years ago 
Exactly, this should be 403. You seem to catch every minor detail Adrien :)

Original comment by yann.col...@gmail.com on 18 Dec 2012 at 9:26

GoogleCodeExporter commented 9 years ago 
The following version corrects the above issue + the "4GB+n" bug you already 
mentioned

Original comment by yann.col...@gmail.com on 18 Dec 2012 at 9:41

Attachments:

GoogleCodeExporter commented 9 years ago 
Thank you, this rc compiles and runs fine on my computer.

Original comment by jpou...@gmail.com on 18 Dec 2012 at 10:17

GoogleCodeExporter commented 9 years ago 
Issue solved with r6.

Original comment by yann.col...@gmail.com on 18 Dec 2012 at 5:01