search

matiasdelellis / facerecognition-external-model

Nextcloud Facerecognition External Model
11 stars 10 forks source link

Support all 4 models #3

Closed guystreeter closed 2 years ago

guystreeter commented 2 years ago

Changes to the external model implementation to support all 4 models, using the FACE_MODEL environment variable, like this:

make FACE_MODEL=4 serve

This should resolve issue #2

guystreeter commented 2 years ago

Should I go ahead and approve these changes? (I think I have write access)

guystreeter commented 2 years ago

I have some more ideas for improvement, but they're based on these changes. I've been using this branch for a while, and it seems to work fine. If these changes are accepted, we could enhance PR #1 to support all models also.

matiasdelellis commented 2 years ago

Hi @guystreeter Thanks for the change... and thanks for taking the trouble to answer some users when I couldn't.. 😄

Although I did not expect to do this, since it is a reference model, and with the expectation that other users will make others models, I like the change, and especially together with #1 I think we can do interesting things. 😃