matiasdelellis / facerecognition

Nextcloud app that implement a basic facial recognition system.
GNU Affero General Public License v3.0
527 stars 47 forks source link

Scrutinizer CI report a lot of use of private api. #191

Open matiasdelellis opened 5 years ago

matiasdelellis commented 5 years ago

Hey, Thanks for reporting issues back to Nextcloud Face Recognition. Please, try to complete this report in detail so we can help you easier. :smile:

Make sure you read all the documentation, and the FAQ, and that the issue has not been reported before. :wink:

Expected behaviour

I hope the Scrutinizer CI reports go clean.

Actual behaviour

Scrutinizer CI a lot of use of private api. See on Scrutinizer CI

Steps to reproduce

  1. Commit an change.
  2. Push to github.
  3. Wait a Scrutinizer CI report.

Server configuration

Client configuration

Logs

Background task log with debug.

sudo -u apache php occ -vvv face:background_job ``` _Not relevant_ ```

Web server error log

Web server error log ``` _Not relevant_ ```

Nextcloud log (data/nextcloud.log)

Nextcloud log ``` _Not relevant_ ```

Browser log

Browser log ``` _Not relevant_ a) The javascript console log b) The network log c) ... ```
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/84356903-scrutinizer-ci-report-a-lot-of-use-of-private-api?utm_campaign=plugin&utm_content=tracker%2F74944432&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F74944432&utm_medium=issues&utm_source=github).
matiasdelellis commented 5 years ago

Maybe most OC\Image reports can be replaced with the \OCP\Preview interface.

https://docs.nextcloud.com/server/latest/developer_manual/api/OCP/Preview/index.html

... or https://docs.nextcloud.com/server/latest/developer_manual/api/OCP/IImage.html?