matiasdelellis / facerecognition

Nextcloud app that implement a basic facial recognition system.
GNU Affero General Public License v3.0
509 stars 46 forks source link

Add support for .heic images #348

Open ntimo opened 3 years ago

ntimo commented 3 years ago

Expected behaviour

.heic images should be scanned and analysed for faces.

Actual behaviour

.heic images are not analysed

Steps to reproduce

  1. Use any apple device to take pictures in .heic format
  2. Wait for them to be analysed
  3. See they are not analysed

Additional Info

It seems to be related to this line there https://github.com/matiasdelellis/facerecognition/blob/b26f39a1b47f7bfe52327548e61c87dba58c9ba7/lib/Service/SettingsService.php#L118 that sets the allowed image formats for the analysis.

Heic mime type image/heic

iOS devices capture photos in the heic format, so having support for it would be huge. (https://support.apple.com/en-us/HT207022)

By the way, the app is amazing thanks for creating it.

ntimo commented 3 years ago

I also tried settings this in my nextcloud config but when I then run the background job the heic images are not processed.

  'enabledFaceRecognitionMimetype' =>
  array (
    0 => 'image/png',
    1 => 'image/jpeg',
    2 => 'image/heic'
  ),
matiasdelellis commented 3 years ago

Hi @ntimo You're right. We have not yet implemented HEIC support. It's on the roadmap, but we still have to wait a bit.. Sorry..

StarSmasher44 commented 2 years ago

Hey there, is this still something that could be added? Most recent phones nowadays have HEIC supported and like mine have it on by default, I actually spent some time trying to debug this 'issue' but I believe it is simply because it is still not supported

matiasdelellis commented 1 year ago

Wow, it took me two years, but I finally got it done. With this, soon a version 1.0. 😬

616

nssatlantis commented 1 year ago

Wow, it took me two years, but I finally got it done. With this, soon a version 1.0. 😬

616

I wouls like to personally say THANK YOU! One of the first to actually support .heic within NextCloud I reckon!