search

matiasdelellis / facerecognition

Nextcloud app that implement a basic facial recognition system.
GNU Affero General Public License v3.0
499 stars 45 forks source link

Images in group folders get scanned again for every user #645

Open lkempf opened 1 year ago

lkempf commented 1 year ago

Expected behaviour

When multiple users have access to the group folder, the analysis results of one user should be used for everyone.

Actual behaviour

Each image in a group folder gets analyzed multiple times.

Steps to reproduce

  1. Create a group folder for all users and upload some images.
  2. Enable analysis for group folders.
  3. Enable face recognition for user 1 and run the background job. All pictures in the group folder will be analyzed.
  4. Enable face recognition for user 2. All face recognition data for images in the group folder is instantly available to the user.
  5. Run the background job. All images in the group folder will be analyzed again.

Server configuration

Logs

Not very interesting. The only thing of note is that cluster creation is skipped for user 2. This might become problem if all pictures of user 2 except for the ones in the group folder have already been analyzed.

Thanks for the great extension. Face recognition is working really well except for this issue with group folders.

sunnyd24 commented 10 months ago

@lkempf

I am likely to face the same issue very soon, and without a GPU available (in Hyper-V) it's taking me approx. 44 seconds to assess all faces in an image, which is a significant overhead if I need to run this for two users with group folders with all my media libraries available.

@matiasdelellis Any plan to allow a shared database (of names/faces) between multiple users for face recognition to reduce overhead on multiple scans for each user that has photos stored in group folders?

szaimen commented 10 months ago

Any plan to allow a shared database (of names/faces) between multiple users for face recognition to reduce overhead on multiple scans for each user that has photos stored in group folders?

I am confused why I am mentioned here. Is this not something that would need to be addressed by the facerecognition app?

matiasdelellis commented 10 months ago

About the bug, it is planned, the same goes for shared images, etc. But a clarification. Names will never be shared. We're just going to avoid double scanning the files.

Simon is right, very kindly he is helping with AIO, but he is not responsible for this application. Do not involve him unless necessary. 😉

sunnyd24 commented 10 months ago

About the bug, it is planned, the same goes for shared images, etc. But a clarification. Names will never be shared. We're just going to avoid double scanning the files.

Simon is right, very kindly he is helping with AIO, but he is not responsible for this application. Do not involve him unless necessary. 😉

Sorry mentioned in error, edited now! My apologies!

dmiales commented 1 month ago

waiting for this feature