search

matiasdelellis / facerecognition

Nextcloud app that implement a basic facial recognition system.
GNU Affero General Public License v3.0
500 stars 45 forks source link

Nextcloud 28: missing icon in sidebar #705

Open pulsejet opened 8 months ago

pulsejet commented 8 months ago

There are a couple of changes to the sidebar with 28:

  1. Tabs can only be registered after DOMContentLoaded
  2. The icon needs to be passed as a raw svg (not data uri or class name)

Should be easy to do this and be backward compatible. Corresponding change in Memories: https://github.com/pulsejet/memories/commit/2ea45cd1c8db1e350d8aa5bfbc079f6d821b15ae

matiasdelellis commented 6 months ago

Hi Varun, Thank you so much! I will fix it soon!. 😄