search

matiasdelellis / facerecognition

Nextcloud app that implement a basic facial recognition system.
GNU Affero General Public License v3.0
510 stars 46 forks source link

Add key support for Imaginary #746

Closed fabalexsie closed 5 months ago

fabalexsie commented 5 months ago

This small PR fixes https://github.com/matiasdelellis/facerecognition/issues/700 where facerecognition is used with Imaginary and Imaginary is configured so that you must provide a key to use it (see h2non/imaginary Authorization).

Unfortunately, I don't have a setup for the latter, so I can't test it myself.

Note: The authorization is implemented by adding the key as query parameter to the requests. As stated in the imaginary readme, it could also be done via an HTTP header as an alternative.

matiasdelellis commented 5 months ago

Wow @fabalexsie I just never see that nextcloud recommend it, so I never took it into account. 😅

p.s. I also have some reservations with the use of imaginary. Personally, the only reason for implementing its support was to be able to read HEIC images and today it is not even necessary.