search

matiasdelellis / facerecognition

Nextcloud app that implement a basic facial recognition system.
GNU Affero General Public License v3.0
510 stars 46 forks source link

button "Review ignored people" to review again ignored/hidden persons #747

Closed wronny closed 4 months ago

wronny commented 5 months ago

Hi, I agree on https://github.com/matiasdelellis/facerecognition/issues/735 - currently ignored/hidden people can only be shown again by making a change within the database. Therefore I added a button "Review ignored people" to review again ignored/hidden persons. This button only appears when ignored/hidden people are found. Screenshot 2024-05-01 221643 Screenshot 2024-05-01 221732 I hope this will be helpful.

matiasdelellis commented 5 months ago

Ohh. Great addition @wronny

These days I will do a review. At first glance I like it, and I just don't understand that sleep(1). 🤔 but if everything is fine I'll probably merge it and then make some changes. 😉

wronny commented 5 months ago

I just don't understand that sleep(1)

if both - new and ignored persons are found - I experienced a random order of both buttons. To delay checking for ignored/hidden persons was a quick workaround to have "Review ignored people" always as second button. Of course feel free to do any changes. This was just my proposal.

matiasdelellis commented 4 months ago

Hi @wronny I'm going to merge it as is and make some changes..

Thanks again..

matiasdelellis commented 4 months ago

Done.. See last commit.. Some things still need to be improved (Modernize the entire script? 🥺), but this was the minimum I wanted to improve now.

Thanks again. With this tomorrow I will upload a new release. 😉