search

matiasgali / guillotine

jQuery plugin to crop images within an area (fully responsive), allowing to drag (touch support), zoom and rotate.
http://guillotine.js.org
326 stars 100 forks source link

When I click on the zoom the page scroll to the top #44

Closed qawsedstation closed 8 years ago

qawsedstation commented 8 years ago

When I click on the zoom the page scroll to the top. If the page is scrolled down. When I press zoom or something else from the controls the page this scroll me up to the top of the page. Any quick fix?

matiasgali commented 8 years ago

Hi @qawsedstation, it doesn't appear to be an issue of the plugin itself but just in case if you provide a JsFiddle or any kind of example I'll take a look at it.

qawsedstation commented 8 years ago

Fix it. Finally was a problem with the demo using the a href # this make the page to go to the top I fix it by using a letter after the hash for example #a

Thanks for the response good work! George On 19 Aug 2015 18:59, "Matías Gagliano" notifications@github.com wrote:

Hi @qawsedstation https://github.com/qawsedstation, it doesn't appear to be an issue of the plugin itself but just in case if you provide a JsFiddle https://jsfiddle.net or any kind of example I'll take a look at it.

— Reply to this email directly or view it on GitHub https://github.com/matiasgagliano/guillotine/issues/44#issuecomment-132722188 .

matiasgali commented 8 years ago

I'm trying the demo but I can't replicate the issue.

The demo even calls event.preventDefault() here for the controls, so the links shouldn't trigger any actions.

Could you tell me what browser are you using?

qawsedstation commented 8 years ago

I test it me too. I get the code from the demo but should effect with something in my code. Should work fine in the demo but react with something else. and Because of the # go to the top of the page. Anyway I fix it just putting #a on the href.

Thanks

2015-08-19 22:44 GMT+01:00 Matías Gagliano notifications@github.com:

I'm trying the demo http://guillotine.js.org but I can't replicate the issue. Could you tell me what browser are you using?

— Reply to this email directly or view it on GitHub https://github.com/matiasgagliano/guillotine/issues/44#issuecomment-132797822 .