Closed tomfitzhenry closed 10 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
11ce28c
) 95.71% compared to head (fe5f165
) 95.71%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks. Yeah, the test is there just a sanity check to ensure that the output is at least plausible…
@tomfitzhenry FYI, I just released v1.1.4 which includes your changes.
@tomfitzhenry FYI, I just released v1.1.4 which includes your changes.
Great, thanks for that! :)
Motivation: Make
cargo test --release
pass. This is useful for NixOS packaging, because NixOS tests against a release binary.Currently the 'test_stdout' fails with
--release
, since the test expects the PDF to be > 400KiB, but the release PDF is 337 KiB.Here we see the debug binary outputting 516 KB:
Here we see the release binary outputting 337KB:
So let's decrease the test limit. I guess the value of the test is mostly in checking that the PDF isn't less than < 10KB. The PDFs are visually indistinguishable from my eye.