Add PageSpeed Insights to SVG

matiassingers / awesome-readme

A curated list of awesome READMEs

18.26k stars 3.84k forks source link

Add PageSpeed Insights to SVG #204

Closed Correia-jpv closed 2 years ago

Correia-jpv commented 2 years ago

Resubmission of #186 as the project is back operational.

Robson commented 2 years ago

Thank you for your submission.

Forgive my complete lack of knowledge about any of this, but I see that the repository is a fork of an actively updated repository. From a cursory glance I can't see any meaningful difference between them, aside from the original being easier to understand. What are the key differences between these repositories?

Correia-jpv commented 2 years ago

The forked repository added new features to the original that were merged. This fork wasn't kept up with the original since then but no major updates were pushed.

Also, at this moment, the original is throwing errors while the forked deployment is up and running.

Robson commented 2 years ago

The forked repository added new features to the original that were merged. This fork wasn't kept up with the original since then but no major updates were pushed.

Also, at this moment, the original is throwing errors while the forked deployment is up and running.

What I'm taking from this is that the key differences between the repositories are:

The fork doesn't have the latest updates that are in the original repository.
The fork fixes an issue in the original repository.
- What is this issue?
- Can we fix the issue in the original repository?

Please correct me if I have misinterpreted that.

Correia-jpv commented 2 years ago

The fork fixes an issue in the original repository.

What is this issue?

It seems to be scalability in the deployment

Robson commented 2 years ago

Can we fix the issue in the original repository?

Robson commented 2 years ago

I'm closing this pull request, because:

No reason has been given in this pull request to use the fork over the original.
An issue was raised about the original repository, but that issue was not occurring when raised and isn't occurring now.
The fork is not up-to-date.
The fork was broken until I raised that issue in the previous pull request.
The original readme is easier to understand.
No answer has been given to the question above.

If a clearly described compelling reason can be found to use the fork, feel free to open a new pull request with that stated.

Alternatively, feel free to raise a pull request to get the original repository added.