Closed benjaoming closed 2 years ago
@benjaoming Thank you for making one of the changes. Just to confirm, do you see that there are more changes required than this?
I would also recommend splitting this into two pull requests:
Thanks for the feedback! I've removed the emojis and added a few more words about what hatch-fancy-pypi-readme
is. I think that the project is highly relevant to the "innovative" thinking of READMEs that champions the spirit of this Awesome List...
I'm getting a bit confused as to why so much is being missed here, so I'll repeat:
Do you see that the review has three items? Only the third item is done.
Do you have an opinion on splitting this into two PRs? It's fine if you want to keep it as one PR, but it's unlikely to ever get approved.
Thanks for the list and good luck!
Making a change on request of the library owner..