search

matiastucci / vue-input-tag

:bookmark: Vue.js 2.0 Input Tag Component
https://tucci.me/vue-input-tag
MIT License
537 stars 130 forks source link

Add some customizations #94

Closed nakeeon closed 5 years ago

nakeeon commented 5 years ago

Using the vue-input-tag I have discovered some limitations. 1) I am not able to dynamically pass a value property. I would like to pass initial tags to the input, but my data loads with some delay, so the input has already mounted and it's innerTags has already initialized. I added watch on value property to update innerTags according to passing value. 2) Default remove icon which is actually a 'x' symbol doesn't fit my design. I would like to override the remove icon. I added a named slot called "remove-icon" for be able to pass a custom remove icon. If slot is empty, then a default 'x' symbol will render.

matiastucci commented 5 years ago

👏 thanks! Why change tags to value though? If we keep the prop name tags we don't need to do a major version change in the package.json. What do you think?

nakeeon commented 5 years ago

@matiastucci I corrected the readme only. The component has a prop called value, not tags. It needs for v-model, I guess

serge1peshcoff commented 5 years ago

Tried the 1st point, was broken for me, now fixed. Thanks a lot!

leeovery commented 5 years ago

Can this fix be tagged and released please?

ChunAllen commented 5 years ago

Can we merge this? I'm also facing this issue.

matiastucci commented 5 years ago

Sorry for the late response. This PR it's now merged and released in 2.0.3.