search

matiasvlevi / Dann

Deep Neural Network Library for JavaScript.
https://dannjs.org
MIT License
425 stars 23 forks source link

made makeXOR #22 #31

Closed shirrsho closed 3 years ago

shirrsho commented 3 years ago

Here's our solution for the issue. Let us know if anything else needs to be done. Thank you.

22

Labnann commented 3 years ago

@matiasvlevi Please check if how we wrote unit test is okay.

Also when the input number < 2, we have made makeXOR return [], Let us know, if it is okay.

22

matiasvlevi commented 3 years ago

The solution looks great! The <2 idea makes sense. Unit tests also look good. Thank you for solving this issue! I'm merging in a few minutes!