The block is broadcasted to only Sqrt(peers) in geth. We observed that in case of validator-sentry architecture, the validator, sometime, might not receive a block which will force the validator to mine on his own, resulting in a reorg.
In this PR, we are making sure that the block will be broadcasted to all the static and trusted peers of a particular node.
Changes
[x] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Changes only for a subset of nodes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
[x] I have added at least 2 reviewer or the whole pos-v1 team
[x] I have added sufficient documentation in code
[x] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
[ ] Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
[ ] Includes RPC methods changes, and the Notion documentation has been updated
Cross repository changes
[ ] This PR requires changes to heimdall
In case link the PR here:
[ ] This PR requires changes to matic-cli
In case link the PR here:
Testing
[ ] I have added unit tests
[ ] I have added tests to CI
[ ] I have tested this code manually on local environment
[ ] I have tested this code manually on remote devnet using express-cli
[ ] I have tested this code manually on mumbai/amoy
[ ] I have created new e2e tests into express-cli
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it
Description
The block is broadcasted to only Sqrt(peers) in geth. We observed that in case of validator-sentry architecture, the validator, sometime, might not receive a block which will force the validator to mine on his own, resulting in a reorg.
In this PR, we are making sure that the block will be broadcasted to all the static and trusted peers of a particular node.
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it