search

maticnetwork / dagger.js

Simple library to connect with dagger server and manage subscriptions for Ethereum Blockchain.
https://matic.network/dagger
MIT License
218 stars 42 forks source link

Problem with Dagger Play #22

Closed Madhuparna04 closed 5 years ago

Madhuparna04 commented 5 years ago

In Dagger Play the event config string is automatically converted into lowercase, because of which there is a problem with using the address which is Case Sensitive. Therefore, currently the Dagger commands using address cannot be run with the Dagger Play.

Madhuparna04 commented 5 years ago

Can I work on this issue?

jdkanani commented 5 years ago

@Madhuparna04 Yeah sure, you can work on this :)

@0xAshish I thought we had fixed this issue before.

0xAshish commented 5 years ago

@Madhuparna04 feel free to open a PR. 😄

Madhuparna04 commented 5 years ago

As mentioned by @ptsayli the error is because the corresponding functionality is not yet added and not because the input string is being converted to lowercase automatically. So, what do I do?

ptsayli commented 5 years ago

In my understanding, @Madhuparna04 is talking about the issue implementation of dagger on Matic website, everything is working fine from dagger side.

closing this PR as this issue has nothing to fix on eth-dagger.