fix: Fix GraphQL 16 upgrade

maticzav / graphql-middleware

Split up your GraphQL resolvers in middleware functions

MIT License

1.15k stars 58 forks source link

Closed giacomorebonato closed 2 years ago

giacomorebonato commented 3 years ago

Upgrade to GraphQL 16 was failing because referencing the property isDeprecated which doesn't exist anymore on GraphQLField.

removed reference to this property since it was used only to take it out from a field object
fixed unit tests to new GraphQL signature
updated Apollo dev dependency

maxpain commented 3 years ago

Any updates?

alexandra-c commented 2 years ago

Hello, we need this in production please, @maticzav @giacomorebonato 😢. Thanks!

maxpain commented 2 years ago

Still no updates?

giacomorebonato commented 2 years ago

I fixed conflicts, but I don't have time to test it at the moment.

wheresrhys commented 2 years ago

I would love this to be released - I'd be happy to help with testing if there's any way I can be useful

giacomorebonato commented 2 years ago

Conflicts fixed again.

hadyrashwan commented 2 years ago

Hey everyone, Any news when the graphql-middleware will move to graphql 16x

hadyrashwan commented 2 years ago

@maticzav Can I help in testing this feature ? As this PR is blocking me and (seems other people too).

sandromartis commented 2 years ago

We are also blocked by this. :( @maticzav Let me know if I can help with testing.

maxpain commented 2 years ago

Any updates?

icazemier commented 2 years ago

Anybody?

sandromartis commented 2 years ago

We ended up removing graphql-middleware and replaced it with resolver composition from graphql-tools: https://www.graphql-tools.com/docs/resolvers-composition

Works well and seems to be maintained.

claytongentry commented 2 years ago

Very nice, thank you @sandromartis

giacomorebonato commented 2 years ago

Closing this. I believe @sandromartis found the best solution.

claytongentry commented 2 years ago

@giacomorebonato does that mean this project is officially no longer maintained?

ehartford commented 2 years ago

https://www.graphql-tools.com/docs/resolvers-composition

do you have an example how to port from graphql-middleware to https://www.graphql-tools.com/docs/resolvers-composition because it's not immediately obvious to me

giacomorebonato commented 2 years ago

Hi @claytongentry , I am afraid so. The PR that I had open was my first attempt to contribute to it, but it was never merged.