search

maticzav / ink-table

📐A table component for Ink.
187 stars 33 forks source link

feat: add support for `ink` 4.0 (BREAKING) #253

Open AlCalzone opened 1 year ago

AlCalzone commented 1 year ago

Note: This PR includes the commit from #252. When #252 is accepted, I can rebase to remove it from the history here.

ink 4.0 is now written in ESM and I had to do some changes to ink-table to make it compatible. Unfortunately, that is a breaking change, since ink-table also needs to be ESM now.

I had to upgrade some dependencies, change how jest is executed, restructure tsconfig to not have VSCode complain in test files. And while I was at it, I changed the default export to a named export (since those have given me too much trouble with bundlers in the past - specifically esbuild).

TasoOneAsia commented 1 year ago

@maticzav Is anything holding this back from landing on main?

I'm currently on an ESM project referencing an ESM-compatible fork, but I would prefer to reference the original package if this can get landed.

dskvr commented 11 months ago

~Appears to be an abandoned project. Someone should just publish this branch to npm as ink-table-v4, any takers?~

😄 https://www.npmjs.com/package/@tqman/ink-table

npm install @tqman/ink-table
yarn add @tqman/ink-table
pnpm install @tqman/ink-table
lougreenwood commented 6 months ago

Is it expected that this be merged and released anytime soon?