search

matildabrown / rWCVP

Generating Summaries, Reports and Plots from the World Checklist of Vascular Plants
https://matildabrown.github.io/rWCVP/
GNU General Public License v3.0
19 stars 0 forks source link

Function names don't include `wcvp` #24

Closed barnabywalker closed 1 year ago

barnabywalker commented 2 years ago

This is my fault - I was originally against putting wcvp in the function names, but I've come around to it and think it is good actually.

So maybe the function names should be, e.g.:

wcvp_match
wcvp_checklist
wcvp_summary
...
matildabrown commented 2 years ago

Agreed! Typing generate_ was killing me for those ones.

barnabywalker commented 2 years ago

candidate function names:

wcvp_match
wcvp_exact?
wcvp_fuzzy?
wcvp_phonetic?

wcvp_checklist
wcvp_summary
wcvp_matrix? wcvp_occ_mat?

wcvp_distribution
wcvp_plot? wcvp_plot_distribution?
matildabrown commented 2 years ago

I like:

wcvp_match (could be wcvp_match_names to indicate the family of functions) wcvp_exact (or wcvp_match_exact) wcvp_fuzzy (or wcvp_match_fuzzy) wcvp_phonetic (or wcvp_match_phonetic) wcvp_checklist wcvp_summary wcvp_summary_gt (indicates that it is a flow-on from wcvp_distribution) wcvp_occ_mat wcvp_distribution wcvp_distribution_map (indicates that it is a flow-on from wcvp_distribution)

Thoughts? Speak now or forever hold your peace (because I don't want to go through all the filenames a second time, even with the help of Ctrl+Shift+F 😅)

matildabrown commented 1 year ago

Updated in 324214eb60bfe94d7870a1b3fbce6b4a753ad102