search

matin / garth

Garmin SSO auth + Connect Python client
MIT License
305 stars 22 forks source link

Fixing sample code in README #50

Closed dhireshjain closed 8 months ago

dhireshjain commented 8 months ago

The sample code was failing with error ImportError: cannot import name 'GarthException' from 'garth' (/opt/homebrew/lib/python3.11/site-packages/garth/__init__.py).

Fixed the sample code.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (668bc61) to head (21e6b1e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 34 34 Lines 1252 1252 ========================================= Hits 1252 1252 ``` | [Flag](https://app.codecov.io/gh/matin/garth/pull/50/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matin+Tamizi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/matin/garth/pull/50/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matin+Tamizi) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matin+Tamizi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matin commented 8 months ago

Good catch. Thanks!