matin / garth

Garmin SSO auth + Connect Python client
MIT License
274 stars 20 forks source link

Fix values as nullable #51

Closed sdenel closed 6 months ago

sdenel commented 6 months ago

Some values can in fact be None in certain circumstances, like when changing from one watch to another

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9b5dfd4) to head (6a8776d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 34 34 Lines 1252 1252 ========================================= Hits 1252 1252 ``` | [Flag](https://app.codecov.io/gh/matin/garth/pull/51/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matin+Tamizi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/matin/garth/pull/51/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matin+Tamizi) | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matin+Tamizi#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matin commented 6 months ago

Looks good. I'll merge and release tomorrow

duarteocarmo commented 6 months ago

@matin, also sleep can be null. (e.g., charging my watch while sleeping)

image

image

duarteocarmo commented 6 months ago

Perhaps we can include that here as well? I think and Optional in stats/sleep should be enough!

matin commented 6 months ago

Released as 0.4.45

@duarteocarmo included your request as well