search

matinlotfali / KDE-Rounded-Corners

Rounds the corners of your windows in KDE Plasma 5 and 6
GNU General Public License v3.0
638 stars 22 forks source link

some types of windows are not rounded #159

Closed Blacksuan19 closed 9 months ago

Blacksuan19 commented 10 months ago

windows with type of dialog and kirigami based windows seem to be ignored.

examples:

Dolphin settings image

About KDE image

Wallpaper settings image

Discover image

matinlotfali commented 9 months ago

Does #161 resolve your issue?

Blacksuan19 commented 9 months ago

half of it, dialog windows are now rounded, however, kirigami dialogs are still not rounded (wallpaper settings, discover) but I suspect that is a limitation of kirigami since most kwin plugins for rounded corners can't round kirigami dialogs or apps in general.

image

image

Blacksuan19 commented 9 months ago

just noticed the effect also applies to the lockscreen now

image

matinlotfali commented 9 months ago

Sadly, I don't seem to be able to access Kirigami dialogs. It looks like they are drawn inside the parent window and they can not be dragged outside of the parent window.

For the lock screen, I can't reproduce it on my end. Despite that, I can exclude the kscreenlocker_greet and ksmserver from the effect.

I just pushed the latest commit in #161.

Blacksuan19 commented 9 months ago

I can confirm the effect doesn't apply to the lockscreen anymore.