matinlotfali / KDE-Rounded-Corners

Rounds the corners of your windows in KDE Plasma 5 and 6
GNU General Public License v3.0
638 stars 22 forks source link

Make outline's opacity independent on window's opacity #225

Closed matinlotfali closed 6 months ago

matinlotfali commented 6 months ago

This is to fix #221

scgm0 commented 6 months ago

There are some side effects.... 图片

matinlotfali commented 6 months ago

@scgm0 can you test #229 and see if it fixes it?

scgm0 commented 6 months ago

@scgm0 can you test #229 and see if it fixes it?

Didn't solve the problem, I tried using vec4 outlineOverlay = vec4(mix(tex.rgb, outlineColor.rgb, outlineColor.a), tex.a); and found that there is still a very shallow outline, maybe there is something else affecting tex.a? 图片

matinlotfali commented 6 months ago

Instead of tex.a > 0.0 in the if condition, can you try tex.a > 0.1?

scgm0 commented 6 months ago

Instead of tex.a > 0.0 in the if condition, can you try tex.a > 0.1?

It played a role!

matinlotfali commented 6 months ago

Fantastic. I will merge it.