matinlotfali / KDE-Rounded-Corners

Rounds the corners of your windows in KDE Plasma 5 and 6
GNU General Public License v3.0
638 stars 22 forks source link

The contours at the rounded corners have a narrower viewing angle #280

Closed scgm0 closed 1 month ago

scgm0 commented 1 month ago

image

image

matinlotfali commented 1 month ago

I don't understand the issue. Can you elaborate?

scgm0 commented 1 month ago

I don't understand the issue. Can you elaborate?

The Outline at the rounded corners, will not look as wide as in the settings, maybe because the anti-aliasing takes up some of the pixels?

matinlotfali commented 1 month ago

I see. You mean at edges it looks 2px but the rounded corner looks 1px. You are right it is definitely the anti-aliasing issue in my implementation, I probably need to add the additional pixel. But let's check more.

I guess when edges are set to 5px the rounded corner looks 4px? Can you check?

scgm0 commented 1 month ago

I see. You mean at edges it looks 2px but the rounded corner looks 1px. You are right it is definitely the anti-aliasing issue in my implementation, I probably need to add the additional pixel. But let's check more.

I guess when edges are set to 5px the rounded corner looks 4px? Can you check?

image

scgm0 commented 1 month ago

1px image

matinlotfali commented 1 month ago

@scgm0 can you check if #285 fixes the issue?

scgm0 commented 1 month ago

@scgm0 can you check if #285 fixes the issue?

1px: image

2px: image

5px: image

scgm0 commented 1 month ago

@scgm0 can you check if #285 fixes the issue?

It looks like it gives the left and right outlines and rounded corners extra pixels, but not the top and bottom outlines.

matinlotfali commented 1 month ago

What you are describing seems similar to #277. Are you using Plasma 6.2?

scgm0 commented 1 month ago

What you are describing seems similar to #277. Are you using Plasma 6.2?

yes 图片

scgm0 commented 1 month ago

What you are describing seems similar to #277. Are you using Plasma 6.2?

Different from #277, I only have this problem in #285, not in master. master 1px: 图片