Message is sent every five minutes

[GoogleCodeExporter]

=================================
V E R Y    S E R I O U S    B U G
=================================

What steps will reproduce the problem?
1. Assume there is a conversation
2. Add a message with first line the time to send, but do not send it
3. Other party in conversation replies (that message is below the unsent one)
4. You reply to the message from the other party.

So the conversation might look like:
- Party 1
- You
- Party 1
- YOUR DRAFT with delimiter and time to send etc
- Another message from Party 1
- Another message from you

What is the expected output? 
- When it is time to send, the message is sent. 
- The conversation no longer contains a draft message.

What do you see instead?
- When it is time to send the message is sent.
- The message is sent EVERY FIVE MINUTES
- The draft remains in the conversation.

What version of the product are you using?
- 8

Please provide any additional information below.
- Before I discovered something was wrong GDS had sent the very same message 19 
times.

Original issue reported on code.google.com by guillaum...@gmail.com on 6 Sep 2013 at 6:03

[GoogleCodeExporter]

Hello guillaumehanique,

Yes, I agree that's a serious bug.. I'll take a look first thing tomorrow!

-Blair

Original comment by blairk...@gmail.com on 6 Sep 2013 at 7:09

[GoogleCodeExporter]

Yeah, this is a big one.  It happened to me in this scenario as well:

A thread with this structure

1. their email
2. my delayed reply (sent)
3. their reply
4. my draft

gmail-delay-send began sending my previous message on the trigger time while I 
was writing my draft.  This only began occurring once my draft was autosaved.

Original comment by tyare...@gmail.com on 10 Sep 2013 at 10:43

[GoogleCodeExporter]

I should mention that my draft in 4. was not set to be delayed.  Only my first 
email had a parsing delimiter.

Original comment by tyare...@gmail.com on 10 Sep 2013 at 10:47

[GoogleCodeExporter]

So it BEGINS if your working of 4 and then never stops?
But if you compose and send 4 before the trigger starts it sends 2 only
once?

It was my assumption that it repeatedly sends 2 because it is followed by a
message of your own (4, but not necessarily a draft).

Original comment by guillaum...@gmail.com on 11 Sep 2013 at 4:47

[GoogleCodeExporter]

Yes, for me it began as soon (within 5 minutes) as my reply was autosaved as a 
draft.  GSD started sending while I was writing my reply and I saw the message 
appear below my draft in the thread.  Keep in mind, the message I was replying 
to was 5 hours old and GSD sent nothing _until_ I started a reply.

I disabled GSD right away, so I don't know if it would've stopped as soon as I 
sent #4.  I'm guessing it would have.  This bug seems dependent on having a 
draft saved.

I noticed one more interesting thing.  In my example, the email GSD sent again 
by mistake was completely trimmed.  Trimmed part of emails have the buttons 
that look like '...' and display 'Show trimmed content' when you mouseover.  So 
this email was blank (it didn't even have my signature), except for the trim 
button.  When I show the content, it displays my email from #2 followed by the 
previous emails as expected.

Original comment by tyare...@gmail.com on 11 Sep 2013 at 5:15

[GoogleCodeExporter]

In my case it started sending every five minutes at the time that was
designated in the mail (2) without an open draft (4). (So in my case 4 was
a sent message)

Original comment by guillaum...@gmail.com on 11 Sep 2013 at 5:54

[GoogleCodeExporter]

I just faced the very same problem! In my case

1. 1 draft mail with a trigger WHICH WAS SENT
2. reply from the recepient.
3. I write another draft with a trigger in the same conversation and save.

GDS started sending the already sent mail, repeatedly (fortunately in my case 
every 10 minutes, since I had set the trigger check to 10 mins!).
The second draft with trigger for the future is not sent ( the trigger was for 
tomorrow).

Original comment by chandan....@gmail.com on 23 Sep 2013 at 2:32

[GoogleCodeExporter]

Yep, just happened for me. Sent my client about 100 emails over the course of 
the night, every five minutes from when I saved the draft to when it was 
supposed to send.

I'm uninstalling this thing pronto!

Original comment by sackh...@gmail.com on 14 Nov 2013 at 6:42

[GoogleCodeExporter]

Same issue here.  Started after I disabled the 'Require label' option.  Sends 
the e-mail every 5 minutes.  Good thing it was just a test e-mail to myself.

Original comment by aroth.ia...@gmail.com on 11 Dec 2013 at 2:23

[GoogleCodeExporter]

I have the same problem.  Seems like gmail-delay-send is failing to delete the 
draft after sending the email.

Original comment by greenber...@gmail.com on 6 Jan 2014 at 1:50

[GoogleCodeExporter]

I've been using the software for 1 week and I think it's a great piece of 
software but unfortunately just can't keep using it, for now anyway. I'll keep 
an eye on this blog to see if anyone comes up with a solution.

Original comment by farci...@arcieroarchitect.com on 2 Feb 2014 at 6:47

[GoogleCodeExporter]

This is the only reason for not using this potentially great software, too. 
Will save this post to see if it's solved in the future.

Original comment by aljo...@gmail.com on 19 Mar 2014 at 11:26

[GoogleCodeExporter]

Hello,

Even with the excellent descriptions on this bug, I wasn't able to reproduce.  
But I think I do understand what the problem was.

I believe the issue has been resolved with: 
https://code.google.com/p/gmail-delay-send/source/detail?r=45f1762efa2e58efe1221
e46adc4368d2a483514

Before I roll this out to everybody I would greatly appreciate if anybody had 
the time to give this new version a try.

It would mean un-installing your current version (instructions: 
https://code.google.com/p/gmail-delay-send/wiki/GmailDelaySendUninstall_8)

Then install by visiting this URL: 
https://script.google.com/macros/s/AKfycbwcIiPu1d5sqUoBsT7zauyRG0VKlA9MIuX-2qX4u
qjWt0RLG0c/exec

The code that is deployed is up to cl/b056eb748f68 from the repository 
(https://code.google.com/p/gmail-delay-send/source/list) and is available for 
viewing 
(https://script.google.com/d/157GDbOU-SSvkckPWyDGD-paXWo41uc1MjeobXNPnZuKTd2LxfE
veEyRn/edit?usp=sharing)

If the testing goes well, and the code deployed I would then ask you to 
un-install this temp version and go back to main line.

Thanks in advance for any feedback,
-Blair

Original comment by blairk...@gmail.com on 1 Apr 2014 at 5:09

[GoogleCodeExporter]

Hi,

I installed the fix. I'll let you know if I find anything.

Original comment by guillaum...@gmail.com on 2 Apr 2014 at 7:18

[GoogleCodeExporter]

Hi,

I've installed the temp version and everything works just fine.

Thanks!

Original comment by ibnua...@gmail.com on 2 Apr 2014 at 8:06

[GoogleCodeExporter]

Thanks for the updates!

I think I'll let this version sit until Monday then roll it out to everybody 
else.

Thanks again,
-Blair

Original comment by blairk...@gmail.com on 2 Apr 2014 at 1:42

[GoogleCodeExporter]

Hi,

I tested it. I cannot reproduce it either (anymore) so you may indeed have
fixed it :-)

Thx!

Original comment by guillaum...@gmail.com on 3 Apr 2014 at 9:30

[GoogleCodeExporter]

Thanks guys for testing this fix!

I've rolled this out to the main version, so if you could revert to that 
version at convenience it would be much appreciated.

I'll leave this temp version running for the rest of the week to give you some 
time.

Thanks,
-Blair

Original comment by blairk...@gmail.com on 8 Apr 2014 at 4:10

• Changed state: Fixed

[GoogleCodeExporter]

Hi Blair,

I had a chance to test it out today. It worked great when accessting gmail on 
pc, but after the message is delayed sent, my android gmail app (by Google) 
does recognized the message sent, But kept the draft between the email threads. 
(And it's shown as draft in the inbox, I might need to send you screen shots of 
my phone for you to fully understand what I'm talking about)

Interstingky, if I go to draft, those message is not found, would you please 
text it out on android? I will send you an email soon, 

Thank you!!

Original comment by lin.cs.s...@gmail.com on 9 Apr 2014 at 1:38

[GoogleCodeExporter]

@Blair

If DelaySend did send the draft at the time indicated in the draft, the draft 
disappears and becomes a message. If I read your comment correctly, that is 
also what happens in your case.

Now the Gmail Website and the Gmail App use the same store. That means that if 
DelaySend converted the draft to a message, then there is no draft anymore. 
That also explains that when you click the draft in your Gmail App that it 
cannot find it (after all: it doesn't exist anymore in the store). 

So the only reason why the Gmail App may still show the draft, is because it 
hasn't synchronized it's view with the Gmail store yet.

Can you force synchronization and check again?

Kind regards,
- Guillaume

Original comment by guillaum...@gmail.com on 9 Apr 2014 at 6:50

[GoogleCodeExporter]

Question: now how do I uninstall the delay-send from #13 (see above) and switch 
back to the main branch?

Original comment by guillaum...@gmail.com on 11 Apr 2014 at 8:37

[GoogleCodeExporter]

Hello,

Sorry, I should have posted those instructions.

To un-install the temp version visit this link (you might have received an 
email with this link when you installed): 
https://script.google.com/macros/d/Mq9l4ZMTp0kCmzrk2B1LVEfRbA25Fyx5W/manage/unin
stall

Then to install the standard version follow the steps here: 
https://code.google.com/p/gmail-delay-send/wiki/GmailDelaySendInstall_8

I'll wait another week before removing the temp version.

-Blair

-Blair

Original comment by blairk...@gmail.com on 15 Apr 2014 at 4:00