search

matiu / dolar-blue

Client for the Dolar blue API in nodejs
24 stars 16 forks source link

Added bluelytics as source, fixed error handling when one URL doesn't wo... #3

Closed sicarul closed 10 years ago

sicarul commented 10 years ago

Added bluelytics as source, fixed error handling when one URL doesn't work and now it returns a Javascript Date instead of a string

Have a nice day :)

matiu commented 10 years ago

Great! Thanks for contributing.

I tested and review the code, everything it is fine. I only have one comment, could you leave LaNacion as the first option if no source is specified at getData()? I think that will be more coherence with present version. thanks!

sicarul commented 10 years ago

All right i will modify it!

matiu commented 10 years ago

@sicarul hey, would you like to make that change so we can merge it? thanks

sicarul commented 10 years ago

I made the change, please check out the latest commit :)

matiu commented 10 years ago

awesome!! Sorry, github doesn't notify updates... :(

sicarul commented 10 years ago

No problem! :) El abr 18, 2014 3:17 PM, "Matias Alejo Garcia" notifications@github.com escribió:

awesome!! Sorry, github doesn't notify updates... :(

— Reply to this email directly or view it on GitHubhttps://github.com/matiu/dolar-blue/pull/3#issuecomment-40831182 .