search

matiu2 / witty-plus

A base application under http://webtoolkit.eu .. adds users and logins
8 stars 4 forks source link

firefox doesn't offer to remember your password #10

Closed matiu2 closed 12 years ago

matiu2 commented 13 years ago

on the login form, firefox isn't offering to remember your password.

might need 'id="password1" or to be surrounded by a form element maybe .. or something ?

matiu2 commented 13 years ago

I don't know why it's not accepting it.

I've changed the id and name of both fields to username and password respectively.

The only other thing I could think of is possibly they need to be put inside a form or something.

matiu2 commented 12 years ago

Found this little gem:

Yes, it doesn't work when you remove return false. You will need to rewrite your code. Chrome does not offer to save passwords from forms that are not "submitted" as a security feature. If you want the Save Password feature to work, you're going to have to ditch the whole fancy AJAX login. – Kranu Nov 8 '10 at 4:02

from: http://stackoverflow.com/questions/4119385/why-doesnt-chrome-recognize-this-login-form

So that's probably it

matiu2 commented 12 years ago

I tried a few different things and I don't think this is gonna be possible without removing the AJAX powerz.

If anyone else can figure it out .. let me know :)

matiu2 commented 12 years ago

So I'm guessing there's a reason chrome only like login forms that do a real post. Is it to prevent XSS attacks or something .. hmm ..

matiu2 commented 12 years ago

I think I'm gonna put "not gonna fix" on this one.

In order to fix it would need at a minimum for the login form to http post the result up to witty. To make it nice, it would need to do it in an iframe.

Witty, really does prefer ajax to http post if it can do it.

Maybe the real witty auth lib will have it.