matkam11 / plex-visualizer

A cool tool to visualize your plex data from plexpy
GNU General Public License v3.0
30 stars 2 forks source link

Issues & improvement suggestions #4

Open mmozeiko opened 7 years ago

mmozeiko commented 7 years ago
  1. Make an option to force people log in with Plex account and not show anything by default. This is to make it easier to host it on public address.

  2. My default screen has Movies and TV Shows as black text on black circle. black_bubbles

  3. Improve how years are shown for "Split Years" option. I have so many different years, that its not readable. (also note a black bubble with black text, unreadable) unreadable_years

  4. It seems that bubbles are not centered in window. For example this is how TV Shows with Split Genres looks for me. not_centered This is also visible in point 3 where right side is cut off by window edge. it seems that centering gets messed up by window resizing.

  5. Not sure in what format I should put APP_URL for plex. I tried http://localhost:32400/ but that generates 500 server error when I try to click on bubble. Tried some different URL's, but nothing worked. Cannot get my metadata shown on click.

  6. Disable console.log logging. Should improve performance on slower computers.

  7. Sometimes when I press reset and then go back in tv shows or movies, it doesn't show all the movies / tv shows, it sill remembers some filters I have put on, but it doesn't show them. Only option is to refresh the page.

matkam11 commented 7 years ago

Thanks for the great feedback! Addressing things one at a time: (Also just leaving myself some initial notes) 1: Thats a reasonable request. Should be a simple flag+check/redirect so shouldn't be hard to do at all! 2 and 3 are related in terms of the black bubbles. I have a pool of colors that it can choose from. I guess I didn't add enough extra!

3: I'm not quite sure what the best way to handle all the years? If you have any thoughts I would appreciate it! I'm thinking through having it group by fives?

  1. I need to make sure the centers get recalculated on window resize

  2. This one is the easiest! Its just the url of this app. (like url of the plex visualizer). Its setup to proxy image requests from PlexPy so that you can leave this in a public space without having PlexPy in a public url

  3. Should just be a function of turning of DEBUG. Should be trivial but will research.

  4. Yeah. I just need to make sure that the filter variables are cleared when the reset function is called.

mmozeiko commented 7 years ago
  1. Yeah, having years in buckets of 5 would be fine by me.

  2. Hmm, that's what I thought initially, but when I put http://localhost:5000/ (I'm running it on same machine I run webrowser) I still get a 500 error. That's why I thought it should be Plex URL.

Anyway's with help of some print's I figured out what's wrong. I was putting PlexPy url in config in wrong format. That's why your code could not parse json and it was throwing exception. What I did I put PLEXPY_URL="http://127.0.0.1:8182/plexpy" which doesn't work. When I changed to PLEXPY_URL="http://127.0.0.1:8182/plexpy/" then everything works.

  1. One more suggestion - allow to click on loaded metadata title. It should open selected media in Plex in a new tab. I'm sure it should be possible to figure out what URL should be from metadata (PlexPy can do it).