search

matkatmusic / ChordieApp_IssueTracker

Issue tracker for ChordieApp
4 stars 0 forks source link

Sustain pedal causes notes to stick after releasing #29

Closed cfaia closed 4 years ago

cfaia commented 4 years ago 
Operating System version Mac OSX 10.15
Steps to reproduce the issue. USe sustain pedal, play some chords, hold the chords and release the pedal, play more chords, some notes are not cleared and stay selected while new notes are added
expected behavior: notes should be cleared when pedal released
behavior actually experienced. notes not cleared
crash log if you happen to have one. no crash
cfaia commented 4 years ago

This also happens when playing notes on the computer keyboard and MIDI keyboard simultaneously. Notes will get stuck and won't clear. Would be nice to have a clear button (panic) so that we don't have to reset to clear it...

matkatmusic commented 4 years ago 
Steps to reproduce the issue. 
USe sustain pedal, 
play some chords, 
hold the chords and release the pedal, 
play more chords, 
some notes are not cleared and stay selected while new notes are added

Can you record a midi file that causes this and attach it or email it? I can't replicate this. Also, the computer keyboard is disabled as an input source for the Piano keyboard at the bottom of the app window. so I'm not sure how you're using the computer keyboard to trigger anything.

If you haven't, please grab the latest build from https://gumroad.com/library and let me know if the bug is still there.

cfaia commented 4 years ago

I’ve done a quick screen recording of the different problems. These problem are random, but persistent.

https://www.dropbox.com/s/ppwyx3f80l1lqly/Screen%20Recording%202020-06-16%20at%2009.55.17.mov?dl=0

C On Jun 16, 2020, 09:40 +0200, matkatmusic notifications@github.com, wrote:

Steps to reproduce the issue. USe sustain pedal, play some chords, hold the chords and release the pedal, play more chords, some notes are not cleared and stay selected while new notes are added Can you record a midi file that causes this and attach it or email it? I can't replicate this. Also, the computer keyboard is disabled as an input source for the Piano keyboard at the bottom of the app window. so I'm not sure how you're using the computer keyboard to trigger anything. If you haven't, please grab the latest build from https://gumroad.com/library and let me know if the bug is still there. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

matkatmusic commented 4 years ago

If you have a different problem, create a separate issue.

matkatmusic commented 4 years ago

Would you mind resetting the database and resetting all settings to default via the menus?

matkatmusic commented 4 years ago

hey @cfaia please let me know if resetting the database solved the issue. it's under the Fretboard menu.

cfaia commented 4 years ago

Yes, this fixes the problem, but there is still the odd stuck note when playing many notes at once very quickly. On Jun 17, 2020, 01:20 +0200, matkatmusic notifications@github.com, wrote:

hey @cfaia please let me know if resetting the database solved the issue. it's under the Fretboard menu. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

matkatmusic commented 4 years ago

Alright, if you can email me a midi file of what you played that triggered this, this will help me to debug and fix this.

matkatmusic commented 4 years ago

hey @cfaia can you email a midi file to me of what you played to trigger this bug?

matkatmusic commented 4 years ago

@cfaia please send me a midi file that triggers this bug!

cfaia commented 4 years ago

Here you go… Sorry, really busy at the moment...

C On Jun 20, 2020, 01:08 +0200, matkatmusic notifications@github.com, wrote:

@cfaia please send me a midi file that triggers this bug! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

matkatmusic commented 4 years ago

@cfaia nothing is attached here. Please send it via email!

lcalder commented 4 years ago

It happens when I play complex music with pedal. It will eventually clear but sometimes can take up to a minute. I think it is trying to look up those increasingly complex chords and each note added will add to the time it takes to do a lookup. To reproduce, just play a chromatic scale with the pedal down. After three octaves, for example, you will have to wait 10 to 15 seconds after you have released the pedal for it to clear.

matkatmusic commented 4 years ago

Duplicate of https://github.com/matkatmusic/ChordieApp_IssueTracker/issues/46