search

matklad / once_cell

Rust library for single assignment cells and lazy statics without macros
Apache License 2.0
1.84k stars 110 forks source link

make once_cell::race::OnceBox available in alloc #121

Closed xu-cheng closed 3 years ago

xu-cheng commented 3 years ago

The CI failed on rust 1.31, whereas the alloc crate was stabilized in rust 1.36.

Is there any suggestion to address this?

xu-cheng commented 3 years ago 
  $ git push --tags --dry-run
  remote: Permission to matklad/once_cell.git denied to github-actions[bot].
  fatal: unable to access 'https://github.com/matklad/once_cell/': The requested URL returned error: 403
PUBLISH: 557.45ms
error: command `git push --tags --dry-run` failed, exit code: 128

This CI error seems to be unrelated to my PR.

matklad commented 3 years ago

@xu-cheng could we change other usages of std to alloc in the same way?

The CI failed on rust 1.31, whereas the alloc crate was stabilized in rust 1.36.

I'll bump MSRV to 1.36

This CI error seems to be unrelated to my PR.

Yup, this shouldn't affect merge, though I wonder why git tag --dry-run does this...

matklad commented 3 years ago

Let's try to merge this though, and leave changes to std to a follow-up PR.

bors r+

matklad commented 3 years ago

could we change other usages of std to alloc in the same way?

Ah, apparently we can't as that needs thread as well. Never mind then!

bors[bot] commented 3 years ago

Build succeeded:

matklad commented 3 years ago

published as 1.5.1, thanks!