search

matklad / once_cell

Rust library for single assignment cells and lazy statics without macros
Apache License 2.0
1.84k stars 110 forks source link

replace parking_lot with parking_lot_core #178

Closed matklad closed 2 years ago

matklad commented 2 years ago

This is primaraliy to enable https://github.com/matklad/once_cell/pull/177 for pl as well

matklad commented 2 years ago

@pitdicker if by any chance you have resources and desire to make a review here, that'd be helpful! No worries if you don't!

matklad commented 2 years ago

Did you consider setting up loupe to actually verify the atomics?

loupe meaning loom? Yeah, I did some manual hacking with loom, and it indeed didn't complain about the current impl, and did complain about relaxed.

Though, pushing that to CI is a bit challenging, as it doesn't support const-fn construction of atomics, something we rely on. Need to think about a nice way to work-around that...

matklad commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Canceled.

matklad commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded: