search

matklad / once_cell

Rust library for single assignment cells and lazy statics without macros
Apache License 2.0
1.87k stars 109 forks source link

correct minor typo and bumped atomic-polyfill #190

Closed jqnatividad closed 2 years ago

matklad commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded:

matklad commented 2 years ago

released as https://crates.io/crates/once_cell/1.13.1

taiki-e commented 2 years ago

FYI, this was a breaking change for users who use the atomic-polyfill feature. (atomic-polyfill itself is not used in the once_cell public API, but the mechanism to implement a critical session implementation in the atomic-polyfill depends on versions of the atomic-polyfill and the critical-section (used in atomic-polyfill), so this can cause a compile error. I can provide reproduction if needed.)

That said, I think this breaking change is justified because atomic-polyfill 1.0 has mitigated/fixed several soundness issues.