search

matklad / once_cell

Rust library for single assignment cells and lazy statics without macros
Apache License 2.0
1.84k stars 110 forks source link

Revert "Make `unsync::Lazy<T, F>` covariant in `F`" #236

Closed danielhenrymantilla closed 1 year ago

danielhenrymantilla commented 1 year ago

Indeed, #233 introduced a regression w.r.t #[may_dangle] 😔, apologies

matklad commented 1 year ago

Absolutely no need to apologize here, it's very useful to know what we actually could do here (pick one of covariance/dropck).

IF you don't want to see the work going to waste, consider submitting a similar PR to rust-lang/rust :0) For std, I think we must get both bits right, and there we #[may dangle].

matklad commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.